Skip to content

Conversation

PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented May 5, 2023

Method "Symfony\Component\DependencyInjection\Extension\ExtensionInterface::load()" might add "void" as a native return type declaration in the future. Do the same in implementation "Twig\Extra\TwigExtraBundle\DependencyInjection\TwigExtraExtension" now to avoid errors or add an explicit @return annotation to suppress this message.

@fabpot
Copy link
Collaborator

fabpot commented May 6, 2023

LGTM but this is a read only repository. Can you submit this change on twig/twig instead?

@fabpot fabpot closed this May 6, 2023
@PhilETaylor
Copy link
Contributor Author

You would think I would learn my lesson by now - so so sorry. Im an idiot.

ScreenShot-2023-05-06-12 12 37

@PhilETaylor PhilETaylor deleted the patch-2 branch May 6, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants