New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the second argument of CallExpression::compileArguments #4105

Merged

fabpot merged 1 commit into twigphp:3.x from fabpot:internal-dep

Jun 18, 2024

Contributor

fabpot commented Jun 17, 2024

No description provided.

xabbuh reviewed

View reviewed changes

src/Node/Expression/CallExpression.php Outdated Show resolved Hide resolved

xabbuh reviewed

View reviewed changes

CHANGELOG Outdated Show resolved Hide resolved

xabbuh reviewed

View reviewed changes

doc/deprecated.rst Outdated Show resolved Hide resolved

xabbuh reviewed

View reviewed changes

CHANGELOG Outdated Show resolved Hide resolved

xabbuh reviewed

View reviewed changes

src/Node/Expression/CallExpression.php Outdated Show resolved Hide resolved

Member

stof commented Jun 18, 2024

the PR title should probably be updated to reflect the actual deprecation

fabpot force-pushed the internal-dep branch from 67a1975 to 87debcb Compare

June 18, 2024 11:52

fabpot changed the title ~~Deprecate CallExpression::compileArguments~~ Deprecate the second argument of CallExpression::compileArguments

Contributor Author

fabpot commented Jun 18, 2024

All fixed now.

xabbuh approved these changes

View reviewed changes

src/Node/Expression/CallExpression.php Outdated

@@ @@ -57,6 +57,10 @@ protected function compileCallable(Compiler $compiler) @@
                   protected function compileArguments(Compiler $compiler, $isArray = false): void
                   {
+                      if (func_num_args() >= 2) {
+                          trigger_deprecation('twig/twig', '3.11', 'Passing a second argument to "%s" is deprecated.', __METHOD__);

Contributor

xabbuh Jun 18, 2024

Suggested change

      
                        trigger_deprecation('twig/twig', '3.11', 'Passing a second argument to "%s" is deprecated.', __METHOD__);
          
                        trigger_deprecation('twig/twig', '3.11', 'Passing a second argument to "%s()" is deprecated.', __METHOD__);


          Deprecate CallExpression::compileArguments

71d6c82

fabpot force-pushed the internal-dep branch from 87debcb to 71d6c82 Compare

June 18, 2024 15:13

fabpot merged commit ca39534 into twigphp:3.x

36 of 37 checks passed

fabpot deleted the internal-dep branch

June 18, 2024 15:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet