Extract the escaping logic to a runtime #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
force-pushed
the
escaper-runtime
branch
7 times, most recently
from
b03c16f to
60c1417
Compare
fabpot
force-pushed
the
escaper-runtime
branch
2 times, most recently
from
aa30dca to
3e742f9
Compare
For once, i'd suggest to add some "magic" because the DX seem a bit odd (to me).. Could we expose directly something like ? $env->getEscaper()With maybe a dedicated interface ? |
I don't think we need a "nicer" DX as using this directly should be the exception, not the rule. |
smnandre
reviewed
Apr 30, 2024
stof
reviewed
May 2, 2024
| * @param string $strategy The strategy name that should be used as a strategy in the escape call | ||
| * @param callable $callable A valid PHP callable | ||
| * @param string $strategy The strategy name that should be used as a strategy in the escape call | ||
| * @param callable(Environment, string) $callable A valid PHP callable |
There was a problem hiding this comment.
The callable also receives the charset as a third argument.
derrabus
added a commit
to symfony/symfony
that referenced
this pull request
May 2, 2024
This PR was merged into the 5.4 branch. Discussion ---------- [WebProfilerBundle] fix compatibility with Twig 3.10 | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT see twigphp/Twig#4055 Commits ------- a4190b5 fix compatibility with Twig 3.10
kbond
added a commit
to symfony/ux
that referenced
this pull request
May 8, 2024
This PR was merged into the 2.x branch. Discussion ---------- [Stimulus] Use Twig >3.9 'EscaperRuntime' | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Issues | Fix #... | License | MIT Resolves CI deprecations (for > Twig 3.9) Twig introduction of EscaperRuntime here: twigphp/Twig#4055 Commits ------- 1fe2ae3 [Stimulus] Use Twig >3.9 'EscaperRuntime'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.