Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-close PRs on subtree-splits #4042

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

kbond
Copy link
Contributor

@kbond kbond commented Apr 18, 2024

---
Please submit your PR here instead:
{$mainRepo}
This repository is what we call a "subtree split": a read-only subset of that main repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing blank line before :)

Comment on lines +50 to +55
However, you should instead open your PR on the main repository:
{$mainRepo}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
However, you should instead open your PR on the main repository:
{$mainRepo}
However, you should instead open your PR on the main repository:
{$mainRepo}

Comment on lines +19 to +21
- name: Fetch branch from where the PR started
run: git fetch --no-tags --prune --depth=1 origin +refs/heads/*:refs/remotes/origin/*

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Fetch branch from where the PR started
run: git fetch --no-tags --prune --depth=1 origin +refs/heads/*:refs/remotes/origin/*

state: "closed"
});
}
EOTXT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
EOTXT
EOTXT

@nicolas-grekas nicolas-grekas force-pushed the autoclose-subtree-issues branch from 2f03eb6 to b212f1b Compare April 19, 2024 06:34
@nicolas-grekas
Copy link
Contributor

Thank you @kbond.

@nicolas-grekas nicolas-grekas merged commit 12625c0 into twigphp:3.x Apr 19, 2024
8 of 9 checks passed
@kbond kbond deleted the autoclose-subtree-issues branch April 20, 2024 17:52
fabpot added a commit that referenced this pull request May 11, 2024
This reverts commit 12625c0, reversing
changes made to ad93431.
@fabpot
Copy link
Contributor

fabpot commented May 11, 2024

Reverted

fabpot added a commit that referenced this pull request May 11, 2024
* 3.x:
  Bump version
  Prepare the 3.10.0 release
  Update CHANGELOG
  Fix markup
  Revert "minor #4042 Auto-close PRs on subtree-splits (kbond)"
  Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants