Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some code style fixes #3509

Merged
merged 1 commit into from
May 14, 2021
Merged

Some code style fixes #3509

merged 1 commit into from
May 14, 2021

Conversation

dionisvl
Copy link
Contributor

@dionisvl dionisvl commented Apr 16, 2021 •
edited
Loading

Fixes that:

  • Type cast is unnecessary
  • Unnecessary curly braces syntax for variable
  • Operations priority might differ that except

fabpot
fabpot requested changes May 12, 2021
View reviewed changes
Copy link
Contributor

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

src/Extension/DebugExtension.php Outdated
// false means that it was not set (and the default is on) or it explicitly enabled
// xdebug.overload_var_dump produces HTML only when html_errors is also enabled
&& (false === ini_get('html_errors') || ini_get('html_errors'))
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be reverted as I don't see any actual changes.

src/Profiler/Dumper/HtmlDumper.php Outdated
$profile->getType(),
self::$colors[$profile->getType()] ?? 'auto',
$profile->getName()
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be reverted

@dionisvl dionisvl requested a review from fabpot May 13, 2021 07:03
@fabpot
Copy link
Contributor

fabpot commented May 14, 2021

Thank you @dionisvl.

@fabpot fabpot merged commit 9e6e700 into twigphp:3.x May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot Awaiting requested review from fabpot

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dionisvl @fabpot