Allow trailing commas in macros + functions + filters #3363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
apfelbox
commented
Jul 6, 2020
| // if the comma above was a trailing comma, early exit the argument parse loop | ||
| if ($stream->test(/* Token::PUNCTUATION_TYPE */ 9, ')')) { | ||
| break; | ||
| } |
There was a problem hiding this comment.
The nice part of this addition here is that it prevents usage with no arguments.
So _self.test(a,) is allowed as macro call, _self.test(,) isn't however.
fabpot
reviewed
Jul 6, 2020
|
@fabpot rebased + update the target branch to also include it in v1. |
|
Thank you @apfelbox. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented support for trailing commas in
Lists + maps are already supported https://twigfiddle.com/6atiz3
Is something missing?