Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle Throwable #2040

Merged
merged 1 commit into from
May 30, 2016
Merged

handle Throwable #2040

merged 1 commit into from
May 30, 2016
+19 −0

Conversation

fprochazka
Copy link
Contributor

@fprochazka fprochazka commented May 13, 2016 •
edited
Loading

Related #2041

@fprochazka fprochazka mentioned this pull request May 13, 2016
Closed
@stof
Copy link
Member

stof commented May 13, 2016

👍

1 similar comment
@nicolas-grekas
Copy link
Contributor

👍

@fabpot
Copy link
Contributor

fabpot commented May 30, 2016

Thank you @fprochazka.

@fabpot fabpot merged commit 99e9d1c into twigphp:1.x May 30, 2016
fabpot added a commit that referenced this pull request May 30, 2016
@fabpot
bug #2040 handle Throwable (fprochazka)
dad282f 
This PR was merged into the 1.x branch.

Discussion
----------

handle Throwable

Related #2041

Commits
-------

99e9d1c handle Throwable
@fprochazka fprochazka deleted the 1.x-php7-throwable branch June 1, 2016 17:48
@CriseX
Copy link

CriseX commented Jun 5, 2016 •
edited
Loading

Doesn't this pull request imply that all previous versions of PHP other than PHP7 are now unsupported, as per PHP migration documentation.

I don't know exactly how the php parser works in this regard, however, intuitively above is true. As long as the Throwable class is not attempted to be loaded unless an exception that inherits said class is thrown the code in this pull request remains backwards compatible, however, if that is not the case then this could break compatibility with all other versions of PHP.

@xabbuh
Copy link
Contributor

xabbuh commented Jun 5, 2016

@CriseX The added lines don't affect execution on older PHP versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fprochazka @stof @nicolas-grekas @fabpot @CriseX @xabbuh