Clarify exception message in Twig_Template::getAttribute #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like a good idea to me. The C extension must also be updated. |
chalasr
force-pushed
the
1.x
branch
4 times, most recently
from
16abb3a to
a84cbd9
Compare
|
@fabpot Thank's for your quick reply. I'm trying to update the C extension, but I'm facing difficulties to use Is there something specific to do in order to use this php function ? I tried to call |
|
|
| @@ -581,7 +581,7 @@ protected function getAttribute($object, $item, array $arguments = array(), $typ | |||
| return; | |||
| } | |||
|
|
|||
| throw new Twig_Error_Runtime(sprintf('Method "%s" for object "%s" does not exist', $item, get_class($object)), -1, $this->getTemplateName()); | |||
| throw new Twig_Error_Runtime(sprintf('Neither the property "%1$s" nor one of the methods "%1$s()", "get%2$s()"/"is%2$s()" or "__call()" exist and have public access in class "%3$s"', $item, ucfirst($item), get_class($object)), -1, $this->getTemplateName()); | |||
There was a problem hiding this comment.
just use 'get'.$item as used when calling the method. PHP method names are case insensitive anyway
There was a problem hiding this comment.
this will help you for the C extension btw, as you won't need to implement ucfirst anymore
chalasr
force-pushed
the
1.x
branch
3 times, most recently
from
fa2b5a9 to
9005969
Compare
Add missing parenthesis Adapt twig.c extension Update the C extension Use php_ucfirst instead of ucfirst Try to implement a TWIG_UCFIRST in C extension Last try ucfirst Rollback twig.c extension Remove useless ucfirst + update twig.c extension Fix mis-escaped char Repeat argument item for sprintf (first try doesnt work) Remove unexpected breakline in code
|
👍 |
2 similar comments
|
👍 |
|
👍 |
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Apr 1, 2016
…e (chalasr) This PR was merged into the 1.x branch. Discussion ---------- Clarify exception message in Twig_Template::getAttribute When a non existing property/method is called for an object, the exception message is: > Method "property()" for object "[class]" does not exist in [template]" But in fact the `Twig_Template::getAttribute()` method check for (at least) 3 more methods (`isProperty()`, `getProperty()` and `__call__()`). It could be more adapted and easier to be debugged if the message would be: > Neither the property "property" nor one of the methods "property]()", "getProperty()"/"isPropertyt()" or "__call()" exist and have public access in class "[class]" in [template] This message is mostly inspired from the one used in the PropertyAccess component. BTW I think that it would be great to replace all the checks listed above by a `PropertyAccessor::isReadable([property])`. I can work on a PR if it's not overkill. Commits ------- d455b52 Clarify exception message in Twig_Template::getAttribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a non existing property/method is called for an object, the exception message is:
But in fact the
Twig_Template::getAttribute()method check for (at least) 3 more methods (isProperty(),getProperty()and__call__()).It could be more adapted and easier to be debugged if the message would be:
This message is mostly inspired from the one used in the PropertyAccess component.
BTW I think that it would be great to replace all the checks listed above by a
PropertyAccessor::isReadable([property]).I can work on a PR if it's not overkill.