Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ignoreStrictCheck option for call_user_func_array, if throwing exception #1286

Merged
merged 3 commits into from
Dec 3, 2013

Conversation

fabpot
Copy link
Contributor

@fabpot fabpot commented Dec 3, 2013

Same as #1236 with added unit tests and C extension support (to come).

"I experienced the issue when using FuelPHP's ORM with EAV containers. When I tried to reference a property that was not defined I expected to get null, but instead the whole application stopped because an exception was thrown in the ORM, that no such function is present.

I couldn't find other possible exception that could be thrown when this function is called, so I assumed it's safe to take the ignoreStrictCheck into consideration here."

tucksaun added a commit to tucksaun/Twig that referenced this pull request Dec 3, 2013
tucksaun added a commit to tucksaun/Twig that referenced this pull request Dec 3, 2013
tucksaun added a commit to tucksaun/Twig that referenced this pull request Dec 3, 2013
fabpot added a commit that referenced this pull request Dec 3, 2013
…y, if throwing exception (fabpot)

This PR was merged into the master branch.

Discussion
----------

Adding ignoreStrictCheck option for call_user_func_array, if throwing exception

Same as #1236 with added unit tests and C extension support (to come).

"I experienced the issue when using FuelPHP's ORM with EAV containers. When I tried to reference a property that was not defined I expected to get null, but instead the whole application stopped because an exception was thrown in the ORM, that no such function is present.

I couldn't find other possible exception that could be thrown when this function is called, so I assumed it's safe to take the ignoreStrictCheck into consideration here."

Commits
-------

1abf5d9 [ext] Mirroring PHP change for call_user_func_array, see #1286
9ab290b added tests for exceptions thrown in __call()
c711d37 Adding ignoreStrictCheck option for call_user_func_array, if throwing exception
@fabpot fabpot merged commit 1abf5d9 into master Dec 3, 2013
@fabpot fabpot deleted the magic-call-exception branch December 3, 2013 14:13
fabpot added a commit that referenced this pull request Dec 21, 2013
* master: (36 commits)
  Fixed rendering of ``-3``
  added an error message when trying to import an undefined block from a trait
  bumped version to 1.15.1-DEV
  prepared the 1.15.0 release
  fixed markup
  [ext] Mirroring PHP change for call_user_func_array, see #1286
  added tests for exceptions thrown in __call()
  Adding ignoreStrictCheck option for call_user_func_array, if throwing exception
  Added min and max function
  fixed typo
  fixed phpdoc
  added TokenStream::nextIf()
  Corrected description of the "//" operator
  [Docs] Fix typos
  [Docs] Some minor fixes: Typos, Notations
  fixed optimizer max value
  Use string instead of large integer
  various cleanups
  added the round filter
  moved README to rst
  ...

Conflicts:
	CHANGELOG
	composer.json
	ext/twig/php_twig.h
	lib/Twig/Environment.php
	lib/Twig/ExistsLoaderInterface.php
	lib/Twig/Extension/Core.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants