Adding ignoreStrictCheck option for call_user_func_array, if throwing exception #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tucksaun
added a commit
to tucksaun/Twig
that referenced
this pull request
Dec 3, 2013
…_user_func_array, see twigphp#1286
tucksaun
added a commit
to tucksaun/Twig
that referenced
this pull request
Dec 3, 2013
tucksaun
added a commit
to tucksaun/Twig
that referenced
this pull request
Dec 3, 2013
fabpot
added a commit
that referenced
this pull request
Dec 3, 2013
…y, if throwing exception (fabpot) This PR was merged into the master branch. Discussion ---------- Adding ignoreStrictCheck option for call_user_func_array, if throwing exception Same as #1236 with added unit tests and C extension support (to come). "I experienced the issue when using FuelPHP's ORM with EAV containers. When I tried to reference a property that was not defined I expected to get null, but instead the whole application stopped because an exception was thrown in the ORM, that no such function is present. I couldn't find other possible exception that could be thrown when this function is called, so I assumed it's safe to take the ignoreStrictCheck into consideration here." Commits ------- 1abf5d9 [ext] Mirroring PHP change for call_user_func_array, see #1286 9ab290b added tests for exceptions thrown in __call() c711d37 Adding ignoreStrictCheck option for call_user_func_array, if throwing exception
fabpot
added a commit
that referenced
this pull request
Dec 21, 2013
* master: (36 commits) Fixed rendering of ``-3`` added an error message when trying to import an undefined block from a trait bumped version to 1.15.1-DEV prepared the 1.15.0 release fixed markup [ext] Mirroring PHP change for call_user_func_array, see #1286 added tests for exceptions thrown in __call() Adding ignoreStrictCheck option for call_user_func_array, if throwing exception Added min and max function fixed typo fixed phpdoc added TokenStream::nextIf() Corrected description of the "//" operator [Docs] Fix typos [Docs] Some minor fixes: Typos, Notations fixed optimizer max value Use string instead of large integer various cleanups added the round filter moved README to rst ... Conflicts: CHANGELOG composer.json ext/twig/php_twig.h lib/Twig/Environment.php lib/Twig/ExistsLoaderInterface.php lib/Twig/Extension/Core.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1236 with added unit tests and C extension support (to come).
"I experienced the issue when using FuelPHP's ORM with EAV containers. When I tried to reference a property that was not defined I expected to get null, but instead the whole application stopped because an exception was thrown in the ORM, that no such function is present.
I couldn't find other possible exception that could be thrown when this function is called, so I assumed it's safe to take the ignoreStrictCheck into consideration here."