11311 object create webhook should be triggered when object is created via rest api #11336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martmull
force-pushed
the
11311-object-create-webhook-should-be-triggered-when-object-is-created-via-rest-api
branch
from
a07b80f to
26f66f5
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The PR integrates webhook triggers for create, update, and delete operations in the REST API, aligning with GraphQL event handling by standardizing event types to TypeORM's ObjectLiteral.
- Updated type usage in /packages/twenty-server/src/engine/api/graphql/graphql-query-runner/services/api-event-emitter.service.ts to use ObjectLiteral for all event actions.
- Integrated ApiEventEmitterService in /packages/twenty-server/src/engine/api/rest/core/rest-api-core-v2.service.ts to emit webhooks post-create, update, and delete, relying on AuthContext.
- Adjusted /packages/twenty-server/src/engine/api/rest/rest-api.module.ts by removing deprecated dependencies and registering ApiEventEmitterService for webhook support.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
martmull
force-pushed
the
11311-object-create-webhook-should-be-triggered-when-object-is-created-via-rest-api
branch
3 times, most recently
from
71897fd to
2068043
Compare
martmull
force-pushed
the
11311-object-create-webhook-should-be-triggered-when-object-is-created-via-rest-api
branch
from
2068043 to
783fcc3
Compare
prastoin
reviewed
Apr 2, 2025
| await this.getRepositoryAndMetadataOrFail(request); | ||
| const createdRecord = await repository.save(body); | ||
|
|
||
| const authContext = this.getAuthContextFromRequest(request); | ||
|
|
||
| if (authContext) { |
There was a problem hiding this comment.
Question: Shouldn't this be an invariant ? Isn't the route guarded by authentication ?
There was a problem hiding this comment.
updated, workspace was optional but there is no reason for that
thomtrp
approved these changes
Apr 2, 2025
prastoin
reviewed
Apr 2, 2025
martmull
deleted the
11311-object-create-webhook-should-be-triggered-when-object-is-created-via-rest-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11311