Revert back to using ar on Darwin (not libtool) #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judah
approved these changes
Aug 9, 2018
| ]) | ||
| hs.actions.run( | ||
|
|
||
| # TODO Get ar location from the CC toolchain. This is |
There was a problem hiding this comment.
We still have an override making hs.tools.ar point to /usr/bin/ar on Mac:
rules_haskell/haskell/toolchain.bzl
Line 145 in 7feaa39
I suggest using hs.tools.ar here, as we do on l.251.
mboes
force-pushed
the
no-libtool-darwin
branch
from
cd7cc47
to
cf6d967
Compare
mboes
force-pushed
the
no-libtool-darwin
branch
from
cf6d967
to
149e3a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #389.