Make a separate toolchain for doctest.
#310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Hazel, we would like `haskell_doctest` to use a `doctest` binary built by Hazel itself. However, since `haskell_binary` depends on the `haskell_toolchain`, which takes the binary as an attribute, doing so would currently cause a dependency loop. (The alternative is to pull it from Nix, which is redundant since Hazel can already build its library dependencies.) Making a separate toolchain breaks the loop, and also seems fairly reasonable since the doctest parameter was already optional in `haskell_toolchain`.
judah
force-pushed
the
doctest-separate-toolchain
branch
from
d3c283a
to
8f7b41b
Compare
|
The corresponding (pending) change to Hazel: FormationAI/hazel@f41e069 |
mboes
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Hazel, we would like
haskell_doctestto use adoctestbinary builtby Hazel itself. However, since
haskell_binarydepends on thehaskell_toolchain, which takes the binary as an attribute, doing so wouldcurrently cause a dependency loop. (The alternative is to pull it from
Nix, which is redundant since Hazel can already build its library
dependencies.)
Making a separate toolchain resolves the loop, and also seems fairly
reasonable since the doctest parameter was already optional in
haskell_toolchain.