fix: output_path and derivation_path may be null or false #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErinvanderVeen
force-pushed
the
37-failure-to-extract-from-githubnixosnixpkgsrelease-2311
branch
from
fb4adae
to
8280062
Compare
sbp
reviewed
Mar 14, 2024
ErinvanderVeen
force-pushed
the
37-failure-to-extract-from-githubnixosnixpkgsrelease-2311
branch
from
8280062
to
610fb89
Compare
ErinvanderVeen
deleted the
37-failure-to-extract-from-githubnixosnixpkgsrelease-2311
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
output_path and derivation_path may be null or false
Issue: #37
Description
The
FoundDrvstruct incorrectly assumed theoutput_pathandderivation_pathwere always String. Unfortunately, this doesn't hold. The values may also benullorfalse. Additionally, I've changed the error return into a warning message, simply skipping any found drvs that we cannot parse.Checklist
Checklist before merging: