refactor: remove BlocksBeingFetched state #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gipphe
reviewed
Jan 27, 2026
Gipphe
reviewed
Jan 27, 2026
Gipphe
requested changes
Jan 27, 2026
Collaborator
Gipphe
left a comment
Gipphe
left a comment
There was a problem hiding this comment.
This PR is arguably somewhat muddled. We've got 3 disparate set of changes happening:
- Removal of
BlocksBeingFetched. - Partial introduction of
withNamespace. - Rework of what
Hoard.Monitoringlogs.
Would you mind splitting these up into at least 2, if not 3, separate PRs? Just ping me on Slack the moment you've got them set up, and I'll provide a swift review to keep the pace going!
Other than that, this is looking very good! It'd be nice to remove the broken implementation of BlocksBeingFetched, and I love what we now get out of Hoard.Monitoring.
|
🎉 All dependencies have been resolved ! |
cgeorgii
force-pushed
the
cgeorgii/simplify-block-fetch
branch
4 times, most recently
from
0da6d24 to
8e7a2a3
Compare
Simplifies the BlockFetch logic by removing the BlocksBeingFetched tracking state. Also improves logging with namespaces and more detailed messages, and enhances monitoring output.
cgeorgii
force-pushed
the
cgeorgii/simplify-block-fetch
branch
from
8e7a2a3 to
65f9fc9
Compare
Gipphe
approved these changes
Jan 28, 2026
prednaz
reviewed
Jan 28, 2026
| refreshImmutableTip :: (Log :> es, NodeToClient :> es, State HoardState :> es) => Eff es () | ||
| refreshImmutableTip = do | ||
| Log.debug "Fetching immutable tip from cardano-node..." | ||
| Log.info "Fetching immutable tip from cardano-node..." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #209
Simplifies
BlockFetchlogic by removing theBlocksBeingFetchedtracking state and theQSemlogic. Also improves logging with namespaces and more detailed messages, and adds some more info to the monitoring output.Let's keep things simple for now so we can iterate faster. We can re-add these later when needed.