Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.net 9 migration #273

Merged
merged 3 commits into from
Nov 14, 2024
Merged

.net 9 migration #273

merged 3 commits into from
Nov 14, 2024

Conversation

twcclegg
Copy link
Owner

Changes

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.27%. Comparing base (8a39ff6) to head (ac35768).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   75.27%   75.27%           
=======================================
  Files          34       34           
  Lines        4424     4424           
  Branches     1001     1001           
=======================================
  Hits         3330     3330           
  Misses        885      885           
  Partials      209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wmundev wmundev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need updating too? https://github.com/twcclegg/libphonenumber-csharp/blob/main/lib/github-actions-metadata-update.sh#L116

otherwise looks good to me, nice one!

@twcclegg twcclegg merged commit 7847c6f into main Nov 14, 2024
6 checks passed
@twcclegg twcclegg deleted the net9 branch November 14, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants