-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add github action pr builds for building project, and running tests on linux and windows #204
feat: add github action pr builds for building project, and running tests on linux and windows #204
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
+ Coverage 81.96% 82.65% +0.68%
==========================================
Files 30 30
Lines 3494 3499 +5
Branches 975 978 +3
==========================================
+ Hits 2864 2892 +28
+ Misses 320 298 -22
+ Partials 310 309 -1 ☔ View full report in Codecov by Sentry. |
cf71c37
to
1fbde8b
Compare
…ests on linux and windows
1fbde8b
to
0a169e7
Compare
…c upgrades for github actions
Hey there, thanks for all your contributions. |
Given all of your work, any interest in becoming a more official collaborator? |
@twcclegg thanks for the link to the issue, i've been trying to replicate the IndexOutOfRangeException issue but to no avail with the code change i made around the path separator, something that might be close that i found is this page here however it doesn't make sense to me as the code change we did should have supported both path separators yeah sure happy to be a official collaborator 👍 |
… PhoneNumberOfflineGeocoder.cs
FYI @twcclegg , these are PR builds to run the unit tests on github actions whenever someone makes a new PR if you are interested in it
github actions are failing because of the zip files delimiter now only supports
\
and not/