Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add github action pr builds for building project, and running tests on linux and windows #204

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

wmundev
Copy link
Collaborator

@wmundev wmundev commented Nov 28, 2023

FYI @twcclegg , these are PR builds to run the unit tests on github actions whenever someone makes a new PR if you are interested in it

github actions are failing because of the zip files delimiter now only supports \ and not /

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6c955e) 81.96% compared to head (7d1dccd) 82.65%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   81.96%   82.65%   +0.68%     
==========================================
  Files          30       30              
  Lines        3494     3499       +5     
  Branches      975      978       +3     
==========================================
+ Hits         2864     2892      +28     
+ Misses        320      298      -22     
+ Partials      310      309       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wmundev wmundev force-pushed the feature/github-action-pr-builds branch from cf71c37 to 1fbde8b Compare November 28, 2023 22:48
@wmundev wmundev force-pushed the feature/github-action-pr-builds branch from 1fbde8b to 0a169e7 Compare December 30, 2023 07:10
@twcclegg
Copy link
Owner

twcclegg commented Jan 2, 2024

Hey there, thanks for all your contributions.
Per the path separator, that seems to have caused some problem #212
Eventually I would like to fully move all of the CI from AppVeyor to GHA; one consideration being, if it's deemed okay to drop running tests on netframework or if it's worth the added complexity of having to add a Windows build step.

@twcclegg
Copy link
Owner

twcclegg commented Jan 2, 2024

Given all of your work, any interest in becoming a more official collaborator?

@wmundev
Copy link
Collaborator Author

wmundev commented Jan 7, 2024

@twcclegg thanks for the link to the issue, i've been trying to replicate the IndexOutOfRangeException issue but to no avail with the code change i made around the path separator, something that might be close that i found is this page here

however it doesn't make sense to me as the code change we did should have supported both path separators

yeah sure happy to be a official collaborator 👍

@wmundev
Copy link
Collaborator Author

wmundev commented Jan 18, 2024

@twcclegg what do you think about this implementation of a safe fallback if the original implementation of the directory char doesn't work? - 7d1dccd

this will resolve the pr builds failing but also ensure original implementation works as expected

@wmundev wmundev requested a review from twcclegg January 18, 2024 07:43
@wmundev wmundev self-assigned this Jan 18, 2024
@wmundev wmundev merged commit 46ef382 into twcclegg:main Jan 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants