Refactor Toast as BaseComponent class with native CSS autohide#42101
Open
anvme wants to merge 1 commit intotwbs:v6-devfrom
Open
Refactor Toast as BaseComponent class with native CSS autohide#42101anvme wants to merge 1 commit intotwbs:v6-devfrom
anvme wants to merge 1 commit intotwbs:v6-devfrom
Conversation
95669bd to
7e6f44a
Compare
7e6f44a to
53a3092
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor Toast from a side-effect-only module (raw document.addEventListener) into a proper BaseComponent class — matching the pattern used by Alert, Button, Tab, and every other Bootstrap component
Motivation & Context
After this discussion, I shared a proposal for replacing JS-heavy components with native browser APIs, similar to what was already done with Modal in v6
Type of changes
Checklist
npm run lint)Live previews
Related issues
https://github.com/orgs/twbs/discussions/42090