Closed
Conversation
mdo
approved these changes
Jul 6, 2025
f4efb1d to
48370d5
Compare
Member
Author
|
Closing for now as we need more thoughts on this. Additionally, Astro currently does not reload when files in |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Heavily draft
This PR follows up on #41574, which introduced automatic Sass recompilation for Astro.
The goal is to identify and remove
watch*npm scripts that are no longer necessary.Currently, these scripts are only triggered through the main
watchscript, which runs when executingnpm run start. There are no known use cases where thewatch-*scripts are run directly.We'll evaluate them one by one.
🟢
watch-js-docsSteps:
watch-js-docsnpm script.npm run start.site/src/assets/stackblitz.js(e.g., change a comment in the HTML).Conclusion:
watch-js-docsis no longer needed and can safely be removed.🔴
watch-css-docsAstro can recompile files like
site/src/scss/_variables.scsson the fly (e.g., to update the$bd-purpleSass variable), but it doesn’t trigger the linter. That’s why we keepwatch-css-docsrunning to executenpm run lintin real time.TODO
watch-css-mainwatch-css-distwatch-css-testwatch-js-mainwatch→watch-*start→watch