-
-
Notifications
You must be signed in to change notification settings - Fork 79.2k
Docs: Add tooltips to buttons when <Example>
is used, not just <Code>
#41582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d not only `<Code>`
<Example>
is called d not only <Code>
<Example>
is called and not only <Code>
<Example>
is called and not only <Code>
<Example>
is used, not just <Code>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, @hannahiss, and thanks for the fix, @louismaximepiton and @MaxLardenois!
The quick fix here is to use
Code
whenever possible (e.g., in theExample
component) so the JS is included wherever needed. It’s not ideal, but it works for now. If you have a better approach to inject the required JS globally, feel free to propose it.
While there might be a cleaner long-term solution, your fix is well-scoped and easy to follow. Let’s move forward with it for now.
I checked a good portion of the docs, and it fixes issues in "Buttons group", several "Helpers" pages like "Color & background", "Colored links", "Stretched link", and more.
… with 2 updates [skip ci] Bumps the security-critical group in /studio with 2 updates: [bootstrap](https://github.com/twbs/bootstrap) and [sweetalert2](https://github.com/sweetalert2/sweetalert2). Updates `bootstrap` from 5.3.7 to 5.3.8 Release notes *Sourced from [bootstrap's releases](https://github.com/twbs/bootstrap/releases).* > v5.3.8 > ------ > > What's Changed > -------------- > > * Streamline release prep script by [`@mdo`](https://github.com/mdo) in [twbs/bootstrap#41539](https://redirect.github.com/twbs/bootstrap/pull/41539) > * Docs: restore local dev port to 9001 by [`@chalin`](https://github.com/chalin) in [twbs/bootstrap#41545](https://redirect.github.com/twbs/bootstrap/pull/41545) > * Docs: use Example shortcode instead of divs with only `.bd-example` class by [`@julien-deramond`](https://github.com/julien-deramond) in [twbs/bootstrap#41556](https://redirect.github.com/twbs/bootstrap/pull/41556) > * Docs: fix scss autorecompile in dev mode by [`@MaxLardenois`](https://github.com/MaxLardenois) in [twbs/bootstrap#41574](https://redirect.github.com/twbs/bootstrap/pull/41574) > * Fix `color-contrast()` function for WCAG 2.1 compliance by [`@julien-deramond`](https://github.com/julien-deramond) in [twbs/bootstrap#41585](https://redirect.github.com/twbs/bootstrap/pull/41585) > * OSSF Scorecard by [`@mdo`](https://github.com/mdo) in [twbs/bootstrap#41571](https://redirect.github.com/twbs/bootstrap/pull/41571) > * Workflows: Use SHA-1 for third-party actions by [`@julien-deramond`](https://github.com/julien-deramond) in [twbs/bootstrap#41595](https://redirect.github.com/twbs/bootstrap/pull/41595) > * Docs: unminify downloadable example HTML files by [`@julien-deramond`](https://github.com/julien-deramond) in [twbs/bootstrap#41637](https://redirect.github.com/twbs/bootstrap/pull/41637) > * Docs: Add tooltips to buttons when `<Example>` is used, not just `<Code>` by [`@louismaximepiton`](https://github.com/louismaximepiton) in [twbs/bootstrap#41582](https://redirect.github.com/twbs/bootstrap/pull/41582) > * Set cursor pointer on input search cancel button by [`@mdo`](https://github.com/mdo) in [twbs/bootstrap#41639](https://redirect.github.com/twbs/bootstrap/pull/41639) > * CSS: Prevent spinner distortion in flex containers with multiline content by [`@julien-deramond`](https://github.com/julien-deramond) in [twbs/bootstrap#41654](https://redirect.github.com/twbs/bootstrap/pull/41654) > * Migrate MyGet script to GH actions by [`@supergibbs`](https://github.com/supergibbs) in [twbs/bootstrap#41583](https://redirect.github.com/twbs/bootstrap/pull/41583) > * Revert "Attempt to return focus explicitly to dropdown trigger" by [`@mdo`](https://github.com/mdo) in [twbs/bootstrap#41668](https://redirect.github.com/twbs/bootstrap/pull/41668) > * docs: Minor range example code optimization by [`@coliff`](https://github.com/coliff) in [twbs/bootstrap#41665](https://redirect.github.com/twbs/bootstrap/pull/41665) > * Remove Themes from docs by [`@mdo`](https://github.com/mdo) in [twbs/bootstrap#41671](https://redirect.github.com/twbs/bootstrap/pull/41671) > * Release v5.3.8 by [`@mdo`](https://github.com/mdo) in [twbs/bootstrap#41669](https://redirect.github.com/twbs/bootstrap/pull/41669) > > Dependencies > ------------ > > * Build(deps-dev): Bump the development-dependencies group with 3 updates by [`@julien-deramond`](https://github.com/julien-deramond) in [twbs/bootstrap#41540](https://redirect.github.com/twbs/bootstrap/pull/41540) > * Build(deps-dev): Bump the development-dependencies group with 2 updates by [`@julien-deramond`](https://github.com/julien-deramond) in [twbs/bootstrap#41544](https://redirect.github.com/twbs/bootstrap/pull/41544) > * Build(deps-dev): Bump stylelint-config-twbs-bootstrap from 16.0.0 to 16.1.0 by [`@julien-deramond`](https://github.com/julien-deramond) in [twbs/bootstrap#41546](https://redirect.github.com/twbs/bootstrap/pull/41546) > * Build(deps-dev): Bump the development-dependencies group with 5 updates by [`@julien-deramond`](https://github.com/julien-deramond) in [twbs/bootstrap#41552](https://redirect.github.com/twbs/bootstrap/pull/41552) > * Build(deps-dev): Bump the development-dependencies group with 4 updates by [`@julien-deramond`](https://github.com/julien-deramond) in [twbs/bootstrap#41560](https://redirect.github.com/twbs/bootstrap/pull/41560) > * Build(deps-dev): Bump the development-dependencies group with 3 updates by [`@julien-deramond`](https://github.com/julien-deramond) in [twbs/bootstrap#41566](https://redirect.github.com/twbs/bootstrap/pull/41566) > * Build(deps): Bump actions/upload-artifact from 4.6.1 to 4.6.2 by [`@dependabot`](https://github.com/dependabot)[bot] in [twbs/bootstrap#41594](https://redirect.github.com/twbs/bootstrap/pull/41594) > * Build(deps-dev): Bump the development-dependencies group with 4 updates by [`@julien-deramond`](https://github.com/julien-deramond) in [twbs/bootstrap#41599](https://redirect.github.com/twbs/bootstrap/pull/41599) > * Build(deps-dev): Bump the development-dependencies group with 2 updates by [`@julien-deramond`](https://github.com/julien-deramond) in [twbs/bootstrap#41609](https://redirect.github.com/twbs/bootstrap/pull/41609) > * Build(deps): Bump github/codeql-action from 3.29.2 to 3.29.3 by [`@dependabot`](https://github.com/dependabot)[bot] in [twbs/bootstrap#41611](https://redirect.github.com/twbs/bootstrap/pull/41611) > * Build(deps): Bump streetsidesoftware/cspell-action from 7.1.1 to 7.1.2 by [`@dependabot`](https://github.com/dependabot)[bot] in [twbs/bootstrap#41610](https://redirect.github.com/twbs/bootstrap/pull/41610) > * Build(deps-dev): Bump the development-dependencies group with 4 updates by [`@julien-deramond`](https://github.com/julien-deramond) in [twbs/bootstrap#41621](https://redirect.github.com/twbs/bootstrap/pull/41621) > * Build(deps): Bump streetsidesoftware/cspell-action from 7.1.2 to 7.2.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [twbs/bootstrap#41625](https://redirect.github.com/twbs/bootstrap/pull/41625) > * Build(deps): Bump actions-cool/issues-helper from 3.6.0 to 3.6.2 by [`@dependabot`](https://github.com/dependabot)[bot] in [twbs/bootstrap#41623](https://redirect.github.com/twbs/bootstrap/pull/41623) > * Build(deps): Bump github/codeql-action from 3.29.3 to 3.29.4 by [`@dependabot`](https://github.com/dependabot)[bot] in [twbs/bootstrap#41624](https://redirect.github.com/twbs/bootstrap/pull/41624) > * Build(deps-dev): Bump the development-dependencies group across 1 directory with 3 updates by [`@dependabot`](https://github.com/dependabot)[bot] in [twbs/bootstrap#41626](https://redirect.github.com/twbs/bootstrap/pull/41626) > * Build(deps): Bump github/codeql-action from 3.29.4 to 3.29.5 by [`@dependabot`](https://github.com/dependabot)[bot] in [twbs/bootstrap#41640](https://redirect.github.com/twbs/bootstrap/pull/41640) > * Build(deps): Bump tmp from 0.2.3 to 0.2.4 by [`@dependabot`](https://github.com/dependabot)[bot] in [twbs/bootstrap#41649](https://redirect.github.com/twbs/bootstrap/pull/41649) > * Build(deps): Bump github/codeql-action from 3.29.7 to 3.29.8 by [`@dependabot`](https://github.com/dependabot)[bot] in [twbs/bootstrap#41657](https://redirect.github.com/twbs/bootstrap/pull/41657) > * Build(deps): Bump actions/checkout from 4.2.2 to 5.0.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [twbs/bootstrap#41655](https://redirect.github.com/twbs/bootstrap/pull/41655) > * Build(deps): Bump github/codeql-action from 3.29.8 to 3.29.10 by [`@dependabot`](https://github.com/dependabot)[bot] in [twbs/bootstrap#41664](https://redirect.github.com/twbs/bootstrap/pull/41664) > > New Contributors > ---------------- > > * [`@chalin`](https://github.com/chalin) made their first contribution in [twbs/bootstrap#41545](https://redirect.github.com/twbs/bootstrap/pull/41545) > > **Full Changelog**: <twbs/bootstrap@v5.3.7...v5.3.8> Commits * [`25aa8cc`](twbs/bootstrap@25aa8cc) Release v5.3.8 ([#41669](https://redirect.github.com/twbs/bootstrap/issues/41669)) * [`122bff5`](twbs/bootstrap@122bff5) Remove Themes from docs ([#41671](https://redirect.github.com/twbs/bootstrap/issues/41671)) * [`320f713`](twbs/bootstrap@320f713) docs: Minor range example code optimization ([#41665](https://redirect.github.com/twbs/bootstrap/issues/41665)) * [`ac5f51c`](twbs/bootstrap@ac5f51c) Revert "Attempt to return focus explicitly to dropdown trigger ([#41365](https://redirect.github.com/twbs/bootstrap/issues/41365))" ([#41](https://redirect.github.com/twbs/bootstrap/issues/41)... * [`4bd8b6c`](twbs/bootstrap@4bd8b6c) Migrate MyGet script to GH actions ([#41583](https://redirect.github.com/twbs/bootstrap/issues/41583)) * [`f50f38b`](twbs/bootstrap@f50f38b) CSS: Fix spinner deformation in flex boxes when content is multiline ([#41654](https://redirect.github.com/twbs/bootstrap/issues/41654)) * [`47c75b8`](twbs/bootstrap@47c75b8) Set cursor pointer on input search cancel button ([#41639](https://redirect.github.com/twbs/bootstrap/issues/41639)) * [`26c86ba`](twbs/bootstrap@26c86ba) Build(deps): Bump github/codeql-action from 3.29.8 to 3.29.10 ([#41664](https://redirect.github.com/twbs/bootstrap/issues/41664)) * [`099b02b`](twbs/bootstrap@099b02b) Build(deps-dev): Bump rollup from 4.46.2 to 4.46.3 * [`4b8a2c9`](twbs/bootstrap@4b8a2c9) Build(deps-dev): bump dependencies * Additional commits viewable in [compare view](twbs/bootstrap@v5.3.7...v5.3.8) Updates `sweetalert2` from 11.22.4 to 11.23.0 Release notes *Sourced from [sweetalert2's releases](https://github.com/sweetalert2/sweetalert2/releases).* > v11.23.0 > -------- > > [11.23.0](sweetalert2/sweetalert2@v11.22.4...v11.23.0) (2025-09-04) > ============================================================================================== > > ### Features > > * replace deprecated word-wrap with overflow-wrap ([2667a49](sweetalert2/sweetalert2@2667a49)) > > v11.22.5 > -------- > > No release notes provided. Changelog *Sourced from [sweetalert2's changelog](https://github.com/sweetalert2/sweetalert2/blob/main/CHANGELOG.md).* > [11.23.0](sweetalert2/sweetalert2@v11.22.4...v11.23.0) (2025-09-04) > ============================================================================================== > > ### Features > > * replace deprecated word-wrap with overflow-wrap ([2667a49](sweetalert2/sweetalert2@2667a49)) Commits * [`fc465a4`](sweetalert2/sweetalert2@fc465a4) chore(release): 11.23.0 [skip ci] * [`2667a49`](sweetalert2/sweetalert2@2667a49) feat: replace deprecated word-wrap with overflow-wrap * [`cf4b189`](sweetalert2/sweetalert2@cf4b189) chore: bump yarn.lock * [`b27bacf`](sweetalert2/sweetalert2@b27bacf) chore: add venuslovedolls to sponsors * [`9dc7802`](sweetalert2/sweetalert2@9dc7802) chore(deps): update dependency cypress to v15 ([#2857](https://redirect.github.com/sweetalert2/sweetalert2/issues/2857)) * [`f824237`](sweetalert2/sweetalert2@f824237) chore: remove code comment that got missed in PR [#2847](https://redirect.github.com/sweetalert2/sweetalert2/issues/2847) ([#2854](https://redirect.github.com/sweetalert2/sweetalert2/issues/2854)) * [`2af063c`](sweetalert2/sweetalert2@2af063c) chore(deps): update dependency eslint-plugin-jsdoc to v54 ([#2851](https://redirect.github.com/sweetalert2/sweetalert2/issues/2851)) * [`80d573e`](sweetalert2/sweetalert2@80d573e) chore(deps): update dependency eslint-plugin-jsdoc to v53 ([#2850](https://redirect.github.com/sweetalert2/sweetalert2/issues/2850)) * [`4a490d5`](sweetalert2/sweetalert2@4a490d5) chore(deps): update actions/checkout action to v5 ([#2849](https://redirect.github.com/sweetalert2/sweetalert2/issues/2849)) * [`47b4da4`](sweetalert2/sweetalert2@47b4da4) Update SPONSORS.md * See full diff in [compare view](sweetalert2/sweetalert2@v11.22.4...v11.23.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore ` will remove the ignore condition of the specified dependency and ignore conditions
Description
I've updated the Example in order to use our Code component.
I've updated Code to be embedded inside other components.
We add a new empty div and a div without any class, but it's better than nothing for now.
Motivation & Context
The issue comes from the fact that the Code component initiates the tooltip both for the clipboard and stackblitz button, but the Code component only embed the clipboard button. On the other side, the Code component is used by JsDocs, ScssDocs and by itself in the documentation (so via ``` and the help of
<Content components={{ pre: Code }} />
inside `[...slug].astro`) but not by the Example component.Previously, it used to work because most pages have either a ``` or a ScssDocs or JsDocs inside the page. Since Astro bundle the JS and clean the bundled JS, if at least one occurrence was present in the page, the Code component JS was interpreted on the whole page and only once. We have the issue on Button Group since we don't have any Code component reference inside.
So here the quick fix is only to use Code whenever it's possible (So in Example component) to add the JS everywhere it's needed. It's not ideal but a quick fix. If you have a better solution to introduce the requested JS everywhere, feel free to change it.
Since the default syntax highlighter is Prism (in
astro.config.ts
) we can't see any difference on the doc.With special thanks to @MaxLardenois.
Type of changes
Checklist
npm run lint
)Live previews
Related issues
Closes #41579