Docs: Enhance Accordion documentation#41501
Merged
julien-deramond merged 1 commit intomainfrom May 27, 2025
Merged
Conversation
julien-deramond
approved these changes
May 27, 2025
Member
julien-deramond
left a comment
There was a problem hiding this comment.
This version works much better in terms of comprehension! I tested the code snippet in this StackBlitz example using the following script:
<script>
const accordionCollapseElementList = document.querySelectorAll('#accordionExample .collapse')
const accordionCollapseList = [...accordionCollapseElementList].map(accordionCollapseEl => new bootstrap.Collapse(accordionCollapseEl))
console.log(accordionCollapseList)
</script>The result is exactly as expected: the first accordion item is collapsed, while the other two are expanded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a space in the collapse selector in the Accordion documentation.
Motivation & Context
Enhance the understanding of the doc to have a list when we mention it.
Type of changes
Checklist
npm run lint)Live previews
Related issues
NA