Skip to content

Docs: Enhance Accordion documentation#41501

Merged
julien-deramond merged 1 commit intomainfrom
main-lmp-accordion-doc-fix
May 27, 2025
Merged

Docs: Enhance Accordion documentation#41501
julien-deramond merged 1 commit intomainfrom
main-lmp-accordion-doc-fix

Conversation

@louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented May 27, 2025

Description

Add a space in the collapse selector in the Accordion documentation.

Motivation & Context

Enhance the understanding of the doc to have a list when we mention it.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

NA

@github-project-automation github-project-automation bot moved this to To do in v5.3.7 May 27, 2025
@louismaximepiton louismaximepiton moved this from To do to Needs review in v5.3.7 May 27, 2025
@julien-deramond julien-deramond self-requested a review May 27, 2025 18:25
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version works much better in terms of comprehension! I tested the code snippet in this StackBlitz example using the following script:

<script>
  const accordionCollapseElementList = document.querySelectorAll('#accordionExample .collapse')
  const accordionCollapseList = [...accordionCollapseElementList].map(accordionCollapseEl => new bootstrap.Collapse(accordionCollapseEl))
  console.log(accordionCollapseList)
</script>

The result is exactly as expected: the first accordion item is collapsed, while the other two are expanded.

@julien-deramond julien-deramond merged commit 81b8153 into main May 27, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from Needs review to Done in v5.3.7 May 27, 2025
@julien-deramond julien-deramond deleted the main-lmp-accordion-doc-fix branch May 27, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants