Skip to content

Examples: remove unused myChart variable#41494

Merged
julien-deramond merged 1 commit intomainfrom
main-jd-dashboard-examples-drop-unused-var
May 25, 2025
Merged

Examples: remove unused myChart variable#41494
julien-deramond merged 1 commit intomainfrom
main-jd-dashboard-examples-drop-unused-var

Conversation

@julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented May 25, 2025

Description

This PR simply removes the myChart unused variables from both Dashboard examples.

As you can see, the examples are still working in the deployed branch on Netlify.

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (N/A) My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond requested a review from a team as a code owner May 25, 2025 12:27
@github-project-automation github-project-automation bot moved this to To do in v5.3.7 May 25, 2025
@julien-deramond julien-deramond moved this from To do to Needs review in v5.3.7 May 25, 2025
@julien-deramond julien-deramond merged commit a61555b into main May 25, 2025
13 checks passed
@julien-deramond julien-deramond deleted the main-jd-dashboard-examples-drop-unused-var branch May 25, 2025 12:29
@github-project-automation github-project-automation bot moved this from Needs review to Done in v5.3.7 May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant