Conversation
Contributor
|
hey @julien-deramond - just curious - do you know why the '@types/google.analytics' devDependency is included? It doesn't look like it's used or needed for anything does it? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps 2 dev dependencies.
The first one is
npm-run-all2from 7.0.2 to 8.0.1. The breaking change of the major version is the "Raise engine floor to >= Node 20" that doesn't concern us as we're already using Node 20. So it's safe to bump on our side.The second one is
eslint-plugin-unicornfrom 55.0.0 to 56.0.1 that contains the following modifications: https://github.com/sindresorhus/eslint-plugin-unicorn/releases/tag/v56.0.0better-regexwas removed from the recommended rules, so we need to removeeslint-disable-next-line unicorn/better-regexthat becomes uselessprefer-global-thisrule generates errors so we can disable it in our.eslintrc.jsonconfigprefer-math-min-maxandconsistent-existence-index-checkdon't generate any errors, so we don't need to disable them in our.eslintrc.jsonconfigRegarding the content of Dependabot PR at #41446, we can't bump the
eslint-plugin-unicornandeslint-config-xopackages for now as the next versions needs ESLint 9.