Skip to content

Update devDependencies#41450

Merged
julien-deramond merged 1 commit intomainfrom
main-jd-bump-deps-7-may
May 7, 2025
Merged

Update devDependencies#41450
julien-deramond merged 1 commit intomainfrom
main-jd-bump-deps-7-may

Conversation

@julien-deramond
Copy link
Member

This PR bumps 2 dev dependencies.

The first one is npm-run-all2 from 7.0.2 to 8.0.1. The breaking change of the major version is the "Raise engine floor to >= Node 20" that doesn't concern us as we're already using Node 20. So it's safe to bump on our side.

The second one is eslint-plugin-unicorn from 55.0.0 to 56.0.1 that contains the following modifications: https://github.com/sindresorhus/eslint-plugin-unicorn/releases/tag/v56.0.0

  • The improvements doesn't imply any changes on our side
  • better-regex was removed from the recommended rules, so we need to remove eslint-disable-next-line unicorn/better-regex that becomes useless
  • The new prefer-global-this rule generates errors so we can disable it in our .eslintrc.json config
  • prefer-math-min-max and consistent-existence-index-check don't generate any errors, so we don't need to disable them in our .eslintrc.json config

Regarding the content of Dependabot PR at #41446, we can't bump the eslint-plugin-unicorn and eslint-config-xo packages for now as the next versions needs ESLint 9.

@julien-deramond julien-deramond requested a review from a team as a code owner May 7, 2025 15:21
@github-project-automation github-project-automation bot moved this to To do in v5.3.7 May 7, 2025
@julien-deramond julien-deramond merged commit 0f19b06 into main May 7, 2025
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-bump-deps-7-may branch May 7, 2025 15:24
@github-project-automation github-project-automation bot moved this from To do to Done in v5.3.7 May 7, 2025
@coliff
Copy link
Contributor

coliff commented May 9, 2025

hey @julien-deramond - just curious - do you know why the '@types/google.analytics' devDependency is included? It doesn't look like it's used or needed for anything does it?

@julien-deramond
Copy link
Member Author

Thanks @coliff, good catch! It was introduced in #38319 because there was something related to Google Analytics at some point, but is indeed not used/useful now. I've dropped it in ac0e962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants