Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fixtureId to FIXTURE_ID for consistency #41150

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

MohamadSalman11
Copy link
Contributor

Description

Updated 'fixtureId' to 'FIXTURE_ID' in getFixture for consistency with constant variable naming convention

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@MohamadSalman11 MohamadSalman11 requested a review from a team as a code owner January 13, 2025 10:39
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @MohamadSalman11!
This change enhances consistency with the codebase by following the existing convention for module-level constants, particularly those used as selectors or identifiers. It aligns well with similar constants like EVENT_KEY, SELECTOR_*, etc., ensuring uniformity across the project.

@julien-deramond julien-deramond merged commit b7f3d6a into twbs:main Feb 8, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants