Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal dialog md breakpoint issue fixed #40610

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Riyazul555
Copy link

@Riyazul555 Riyazul555 commented Jul 7, 2024

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #40591

@Riyazul555 Riyazul555 requested a review from a team as a code owner July 7, 2024 07:54
@poswalsameer
Copy link

Hi @julien-deramond, I am working on this issue, can you please assign this to me?

@poswalsameer
Copy link

Hi @louismaximepiton, can I know the reason for my PR getting closed? So, that I can improve on it.

@louismaximepiton
Copy link
Member

As mentioned in #40733, your PR was a duplicate of this one, which we had no time to look at, just keeping the repository tidy.

@poswalsameer
Copy link

As mentioned in #40733, your PR was a duplicate of this one, which we had no time to look at, just keeping the repository tidy.

sure, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the modal dialog there is no md breakpoint
5 participants