masthead.html: add rel="noopener" target="_blank"
#39805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
approved these changes
Mar 19, 2024
Member
julien-deramond
left a comment
julien-deramond
left a comment
There was a problem hiding this comment.
LGTM! Consistent with the other external links we have in the docs.
Note: If it's merged, we should modify the v3 part of gh-pages that have the EOL banner too; right now we have:
- v3:
<a href="https://www.herodevs.com/support/nes-bootstrap?utm_source=Bootstrap_site&utm_medium=Banner&utm_campaign=v3_eol">Never-Ending Support</a> - v4:
<a href="https://www.herodevs.com/support/nes-bootstrap?utm_source=Bootstrap_site&utm_medium=Banner&utm_campaign=v4_eol" target="_blank" rel="noopener">Never-Ending Support</a>
romankupchak93
pushed a commit
to romankupchak93/bootstrap
that referenced
this pull request
Apr 25, 2024
(cherry picked from commit a0912dc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation & Context
Type of changes
Checklist
npm run lint)Live previews
Related issues