Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert build scripts to ESM #38984

Merged
merged 7 commits into from
Aug 6, 2023
Merged

Convert build scripts to ESM #38984

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eff639b
Convert build scripts to ESM
XhmikosR Jul 31, 2023
15e4bc0
Update zip-examples.mjs
XhmikosR Aug 1, 2023
b31afba
Update zip-examples.mjs
XhmikosR Aug 1, 2023
c80107f
Merge branch 'main' into xmr/build-scripts-esm
XhmikosR Aug 1, 2023
a91b5fa
Merge branch 'main' into xmr/build-scripts-esm
XhmikosR Aug 2, 2023
d826d4a
rollup.config.mjs: rename variable
XhmikosR Aug 2, 2023
537170c
Merge branch 'main' into xmr/build-scripts-esm
XhmikosR Aug 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rollup.config.mjs: rename variable
  • Loading branch information
@XhmikosR
XhmikosR committed Aug 2, 2023
commit d826d4a6320e586d2ec8fa6c15dd0e6075c94644
6 changes: 3 additions & 3 deletions build/rollup.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const __dirname = path.dirname(fileURLToPath(import.meta.url))
const BUNDLE = process.env.BUNDLE === 'true'
const ESM = process.env.ESM === 'true'

let fileDestination = `bootstrap${ESM ? '.esm' : ''}`
let destinationFile = `bootstrap${ESM ? '.esm' : ''}`
const external = ['@popperjs/core']
const plugins = [
babel({
Expand All @@ -26,7 +26,7 @@ const globals = {
}

if (BUNDLE) {
fileDestination += '.bundle'
destinationFile += '.bundle'
// Remove last entry in external array to bundle Popper
external.pop()
delete globals['@popperjs/core']
Expand All @@ -43,7 +43,7 @@ const rollupConfig = {
input: path.resolve(__dirname, `../js/index.${ESM ? 'esm' : 'umd'}.js`),
output: {
banner: banner(),
file: path.resolve(__dirname, `../dist/js/${fileDestination}.js`),
file: path.resolve(__dirname, `../dist/js/${destinationFile}.js`),
format: ESM ? 'esm' : 'umd',
globals,
generatedCode: 'es2015'
Expand Down