-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase contrast in dark-mode (#38525) #38815
Conversation
This increases the default brightness for the body text-color in dark mode, which inceases readability a bit. It was also suggested to darken the background a bit, but we unfortunately don't have a darker gray in our color palette. So for now, let's increase the text-color by two notches, and leave the background color as-is instead.
This matches the work-around I implemented for mesa3d.org. |
Worth to note, this increases the contrast ratio from 8.22 to 13.1. |
It's not white, it's just a bit closer to white. FWIW, the contrast between the body-text and the headings are now more similar to what we do for light mode, which seems like a good thing to me: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like a great first start to me, thanks!
Description
This increases the default brightness for the body text-color in dark mode, which inceases readability a bit.
It was also suggested to darken the background a bit, but we unfortunately don't have a darker gray in our color palette. So for now, let's increase the text-color by two notches, and leave the background color as-is instead.
Motivation & Context
See issue #38525
Type of changes
Checklist
npm run lint
)(not really sure any of the above applies here)
Live previews
Related issues
#38525