Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update buttons.md #38736

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Update buttons.md #38736

merged 1 commit into from
Jul 6, 2023

Conversation

parthibanb224
Copy link
Contributor

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@XhmikosR XhmikosR requested a review from mdo June 13, 2023 21:06
mdo
mdo approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@mdo mdo merged commit 6301ca1 into twbs:main Jul 6, 2023
@XhmikosR XhmikosR added the skip-changelog So that the release drafter action doesn't include it label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
docs skip-changelog So that the release drafter action doesn't include it v5
Projects
No open projects
v5.3.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parthibanb224 @mdo @XhmikosR @julien-deramond