Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selectors for carousel media query color mode option #38328

Merged
merged 2 commits into from
Mar 26, 2023

Conversation

mdo
Copy link
Member

@mdo mdo commented Mar 25, 2023

Complementary fix to go with #38326.

This adds a check on the $color-mode-type to our carousel dark mode selector to ensure we're not sending a root level & selector.

/cc @julien-deramond

@mdo mdo requested a review from a team as a code owner March 25, 2023 19:21
@julien-deramond julien-deramond linked an issue Mar 26, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Build error in carousel.scss when using $color-mode-type: media-query
2 participants