Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove version comment from JavaScript src files #38294

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Remove version comment from JavaScript src files #38294

merged 3 commits into from
Mar 22, 2023

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Mar 21, 2023 •
edited by XhmikosR
Loading

Description

Just remove the version info from the comments area (prompted by @XhmikosR)

Motivation & Context

Minimize the impact of version change

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@GeoSot GeoSot requested a review from XhmikosR March 21, 2023 15:06
@XhmikosR XhmikosR removed the build label Mar 22, 2023
@XhmikosR XhmikosR changed the title Remove version comment from javascript src files Remove version comment from JavaScript src files Mar 22, 2023
@XhmikosR XhmikosR marked this pull request as ready for review March 22, 2023 07:08
@XhmikosR XhmikosR requested a review from a team as a code owner March 22, 2023 07:08
@XhmikosR XhmikosR merged commit ab049cd into main Mar 22, 2023
@XhmikosR XhmikosR deleted the gs/remove-version-from-js-files-comments branch March 22, 2023 07:12
@XhmikosR XhmikosR mentioned this pull request Mar 22, 2023
Merged
10 tasks
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

Assignees
No one assigned
Labels
js
Projects
No open projects
v5.3.0-alpha2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeoSot @XhmikosR