Skip to content

Conversation

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 15, 2023

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@twbs twbs locked and limited conversation to collaborators Mar 15, 2023
@julien-deramond julien-deramond self-requested a review March 15, 2023 19:58
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All occurrences of -alpha1 have been changed to -alpha2.
Running locally npm run release gives me the same output.
LGTM!

@XhmikosR XhmikosR force-pushed the xmr/prepare-530-alpha2 branch 10 times, most recently from abc8088 to cd1daad Compare March 23, 2023 06:08
@XhmikosR XhmikosR force-pushed the xmr/prepare-530-alpha2 branch 3 times, most recently from 4a51d80 to 9125e31 Compare March 24, 2023 14:07
@XhmikosR XhmikosR force-pushed the xmr/prepare-530-alpha2 branch from 9125e31 to 3eefa52 Compare March 24, 2023 14:12
@XhmikosR XhmikosR marked this pull request as ready for review March 24, 2023 14:23
@XhmikosR XhmikosR requested review from a team as code owners March 24, 2023 14:23
@XhmikosR XhmikosR merged commit c877cef into main Mar 24, 2023
@XhmikosR XhmikosR deleted the xmr/prepare-530-alpha2 branch March 24, 2023 14:30
@XhmikosR XhmikosR added the skip-changelog So that the release drafter action doesn't include it label Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release skip-changelog So that the release drafter action doesn't include it squash

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants