Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nesting color modes docs section #38192

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Remove nesting color modes docs section #38192

merged 2 commits into from
Mar 8, 2023

Conversation

mdo
Copy link
Member

@mdo mdo commented Mar 8, 2023

Officially drops full support for nesting light mode components within dark mode components, given the issues around needing to duplicate selectors. For those following along, or finding this later, this is essentially what we'd need to do to properly support nesting light in dark:

.carousel,
.carousel[data-bs-theme="light"],
[data-bs-theme="light"] .carousel {
 //...
}

And this would need to be applied to basically every single selector. For the time being, this just isn't practical, and most likely not even that useful.

Closes #38065.

@mdo mdo changed the title Update docs for nesting color modes Remove nesting color modes docs section Mar 8, 2023
@julien-deramond julien-deramond self-requested a review March 8, 2023 05:49
@mdo mdo merged commit a3f8480 into main Mar 8, 2023
@mdo mdo deleted the color-modes-docs-note branch March 8, 2023 05:53
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants