Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs on Modals, Alerts, Offcanvas and Toasts close triggers examples #38182

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

hannahiss
Copy link
Contributor

@hannahiss hannahiss commented Mar 7, 2023

Description

  • "Dismissal can be achieved with the data attribute on a button" changed to "Dismissal can be achieved with the data-bs-dismiss attribute on a button" for more understandable indication
  • "using the data-bs-target" changed to "using the additional data-bs-target" for more complete indication
  • change outside button class from btn-close to btn btn-primary since an outside button is unlikely to be a cross button

Motivation & Context

Makes the documentation more understandable and precise.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Co-authored-by: Julien Déramond <juderamond@gmail.com>
@mdo
Copy link
Member

mdo commented Mar 10, 2023

Thanks!

@mdo mdo merged commit fd7cfac into twbs:main Mar 10, 2023
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants