Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizable breakpoints for navbars #36521

Closed
wants to merge 5 commits into from
Closed

Conversation

pine3ree
Copy link
Contributor

@pine3ree pine3ree commented Jun 7, 2022

We usually do not need so many breakpoints for navbars as for grids: see #36517 for feature description.

@pine3ree pine3ree requested a review from a team as a code owner June 7, 2022 13:08
scss/_variables.scss Outdated Show resolved Hide resolved
@@ -1082,7 +1082,6 @@ $nav-pills-link-active-bg: $component-active-bg !default;

// Navbar

// scss-docs-start navbar-variables
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be restored.

@@ -6,6 +6,10 @@
$theme-colors-rgb: map-loop($theme-colors, to-rgb, "$value") !default;
// scss-docs-end theme-colors-rgb

// scss-docs-start navbar-breakpoints
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document this on the navbar page as well?

@pine3ree
Copy link
Contributor Author

Closed in favor of #38909

@pine3ree pine3ree closed this Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

3 participants