Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Doc: remove role="group" from some split drop* buttons #36254

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions js/tests/visual/dropdown.html
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ <h1>Dropdown <small>Bootstrap Visual Test</small></h1>
</div>

<div class="col-sm-12 mt-4">
<div class="btn-group dropup" role="group">
<div class="btn-group dropup">
<a href="#" class="btn btn-secondary">Dropup split align right</a>
<button type="button" id="dropdown-page-subheader-button-3" class="btn btn-secondary dropdown-toggle dropdown-toggle-split" data-toggle="dropdown" aria-expanded="false">
<span class="sr-only">Product actions</span>
Expand All @@ -117,7 +117,7 @@ <h1>Dropdown <small>Bootstrap Visual Test</small></h1>
</div>

<div class="col-sm-12 mt-4">
<div class="btn-group dropright" role="group">
<div class="btn-group dropright">
<a href="#" class="btn btn-secondary">Dropright split</a>
<button type="button" id="dropdown-page-subheader-button-4" class="btn btn-secondary dropdown-toggle dropdown-toggle-split" data-toggle="dropdown" aria-expanded="false">
<span class="sr-only">Product actions</span>
Expand All @@ -139,7 +139,7 @@ <h1>Dropdown <small>Bootstrap Visual Test</small></h1>
</div>
</div>
<!-- dropleft -->
<div class="btn-group dropleft" role="group">
<div class="btn-group dropleft">
<a href="#" class="btn btn-secondary">Dropleft split</a>
<button type="button" id="dropdown-page-subheader-button-5" class="btn btn-secondary dropdown-toggle dropdown-toggle-split" data-toggle="dropdown" aria-expanded="false">
<span class="sr-only">Product actions</span>
Expand Down
4 changes: 2 additions & 2 deletions site/content/docs/4.6/components/dropdowns.md
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ Trigger dropdown menus at the left of the elements by adding `.dropleft` to the
</div>
</div>
<div class="btn-group">
<div class="btn-group dropleft" role="group">
<div class="btn-group dropleft">
<button type="button" class="btn btn-secondary dropdown-toggle dropdown-toggle-split" data-toggle="dropdown" aria-expanded="false">
<span class="sr-only">Toggle Dropleft</span>
</button>
Expand Down Expand Up @@ -519,7 +519,7 @@ Trigger dropdown menus at the left of the elements by adding `.dropleft` to the

<!-- Split dropleft button -->
<div class="btn-group">
<div class="btn-group dropleft" role="group">
<div class="btn-group dropleft">
<button type="button" class="btn btn-secondary dropdown-toggle dropdown-toggle-split" data-toggle="dropdown" aria-expanded="false">
<span class="sr-only">Toggle Dropleft</span>
</button>
Expand Down