Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devDependencies #36120

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Update devDependencies #36120

merged 2 commits into from
Apr 8, 2022

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Apr 5, 2022

  • @popperjs/core ^2.11.4 → ^2.11.5
  • clean-css-cli ^5.5.2 → ^5.6.0
  • karma-rollup-preprocessor ^7.0.8 → ^7.0.7
  • stylelint 14.2.0 → 14.6.1

@XhmikosR XhmikosR marked this pull request as ready for review April 5, 2022 15:37
@XhmikosR XhmikosR requested a review from a team as a code owner April 5, 2022 15:37
@XhmikosR XhmikosR requested review from ffoodd and GeoSot April 5, 2022 15:38
XhmikosR added 2 commits April 8, 2022 09:13
* @babel/core                ^7.17.8  →  ^7.17.9
* @popperjs/core             ^2.11.4  →  ^2.11.5
* clean-css-cli               ^5.5.2  →   ^5.6.0
* eslint-plugin-import       ^2.25.4  →  ^2.26.0
* find-unused-sass-variables  ^4.0.3  →   ^4.0.4
* karma-rollup-preprocessor   ^7.0.8  →   ^7.0.7
* sass                      ^1.49.11  →  ^1.50.0
* stylelint                   14.2.0  →  ^14.6.1
@XhmikosR XhmikosR merged commit 7648848 into main Apr 8, 2022
@XhmikosR XhmikosR deleted the deps branch April 8, 2022 06:17
@julien-deramond
Copy link
Member

@XhmikosR Got a group of questions regarding the "currentColor""currentcolor" modification:

  • I don't know if you're aware of that but there is a remaining currentColor in
    border: var(--#{$prefix}spinner-border-width) solid currentColor;
    not detected automatically.
  • There are remaining currentColor in some Markdown files (migration.md, placeholders.md, spinners.md). I suppose it is normal that they are not automatically detected, but is a modification needed here?
  • There are remaining currentColor in the SVGs (inline in Markdown files or in .svg files). Is a modification needed in your opinion?

@XhmikosR
Copy link
Member Author

@julien-deramond sorry for the late reply:

  1. I guess it's an issue in stylelint or stylelint-scss so it should be reported there
  2. we could change those instances too later for consistency assuming the first point is also fixed
  3. not sure about SVGs, it might be OK nowadays to use the lowercase attribute but I wouldn't bother with them at this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants