Collapse.js: Tweak active children selector, to search only .collapsing & .collapse.show
#35692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this covered by tests? Or rather, could you add a test please? :) |
GeoSot
force-pushed
the
gs/tweak-collapse-js-selector
branch
from
8cfb28c to
b82ba84
Compare
GeoSot
force-pushed
the
gs/tweak-collapse-js-selector
branch
from
5f933fb to
6ad4548
Compare
mdo
force-pushed
the
gs/tweak-collapse-js-selector
branch
from
6ad4548 to
c3a6945
Compare
…ing` as for ui reasons, during show/hide, we toggle `.collapse` class too
GeoSot
force-pushed
the
gs/tweak-collapse-js-selector
branch
from
c3a6945 to
49cfa8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak active children selector, to search only
.collapsingas for ui reasons, during show/hide, we toggle.collapseclass tooExplanation: Seems like that in order to achieve smooth transitions during toggling, we toggle
.collapseclass too. So the activeChildren selection fails to include transitioning instances, between quick switchingcontradicts #25161
closes #35685