-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RTL examples #33097
Update RTL examples #33097
Conversation
Thanks a lot for tackling this, this is highly appreciated! |
Do I really have to rebase? it's really creating a bunch of unneeded commits. |
8d499c0
to
ceed03a
Compare
It shouldn't, but if your PR is ready we'll rebase it by ourselves if needed. |
@@ -195,7 +198,7 @@ <h4 class="fst-italic">في مكان آخر</h4> | |||
</main><!-- /.container --> | |||
|
|||
<footer class="blog-footer"> | |||
<p>تم تصميم نموذج المدونة لـ <a href="https://getbootstrap.com/"> Bootstrap </a> بواسطة <a href="https://twitter.com/mdo">mdo</a>.</p> | |||
<p>تم تصميم نموذج المدونة لـ <a href="https://getbootstrap.com/">Bootstrap</a> بواسطة <a href="https://twitter.com/mdo"><bdi lang="en" dir="ltr">@mdo</bdi></a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snapshoting this in my mind for our future bi-di example templates ❤️
@aqeelat We prioritized some examples in our first implementation —based on how much they'd change in RTL— but feel free to add some of the other ones if you feel it makes sense. In #32330 I added in the "Need help" part a topic regarding bi-directional templates. We don't have any of them and I'm not sure how to tackle this, so if you have any insights (or even bi-di contents in the wild) that could help a lot. We really need some examples in order to document how-to for bi-di layouts since it'd been asked a few times already. This PR is pushing the overall quality of our RTL support a lot, that's unvaluable so thanks a lot! |
@ffoodd I'm glad I was able to help. As for bi-di, I already used it extensively in the cheatsheet. Check out the tables there. However, I'll try to come up with a dedicated example. |
Reminder: we would need to recreate the screenshots before the merge. |
Would it make any sense to use eastern Arabic numerals in examples, @aqeelat? This is the exact kind of details we need help for, since we don't have any Arabic speaker in the team. Your efforts are highly appreciated! |
@ffoodd Many Arabic speakers use Hindu numerals. I guess it makes sense to use them in the examples. I'll update the examples. |
@aqeelat Friendly ping here, do you think it's safe to merge or do you see anything else to do—apart from new screenshots, which I'll handle? |
I'm sorry I was crazy busy in the past couple of weeks. I'll do a final review and update you within 24 hours. |
No worry nor hurry, just wanted to check back if we didn't forget this 🙂 |
Looks good to me. I think it's ready to be merged. |
And for the Hindu-Arabic numerals comment that was mentioned in another PR of mine, I'm a strong believer that Arabic text should have Arabic numerals, and therefore we should not replace them in these examples. |
Fair enough, thanks a lot! |
Hi,
The current RTL examples have many inconsistencies and mistranslations. I'm taking a deeper look and translating them better.
Don't merge yet.