Skip to content

Conversation

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Dec 14, 2020

@twbs twbs locked and limited conversation to collaborators Dec 14, 2020
@XhmikosR XhmikosR force-pushed the v5.0.0-beta2-prep branch 3 times, most recently from 84a804d to 3b3a20d Compare December 17, 2020 06:11
@XhmikosR XhmikosR force-pushed the v5.0.0-beta2-prep branch 2 times, most recently from 0b57319 to 5dab2db Compare December 22, 2020 21:33
@XhmikosR XhmikosR force-pushed the v5.0.0-beta2-prep branch 3 times, most recently from bf48abd to 4a25c28 Compare January 13, 2021 20:02
@XhmikosR XhmikosR force-pushed the v5.0.0-beta2-prep branch 5 times, most recently from a4814f4 to 64c5323 Compare January 20, 2021 14:47
@XhmikosR XhmikosR force-pushed the v5.0.0-beta2-prep branch 4 times, most recently from e017d6a to 1acb337 Compare February 3, 2021 15:20
@XhmikosR XhmikosR force-pushed the v5.0.0-beta2-prep branch 2 times, most recently from bc13320 to a96ad0c Compare February 9, 2021 06:39
@XhmikosR
Copy link
Member Author

XhmikosR commented Feb 9, 2021

@ffoodd can you please have a quick look at the dist CSS changes so that we make sure everything's alright?

@ffoodd
Copy link
Member

ffoodd commented Feb 9, 2021

Seems good to me, I recognize every change with a single exception than I'm unable to trace back: some .fs-*-* utilities are removed, but I can't even find where they were coming from 🤔

@MartijnCuppens Might it relate to RFS?

@XhmikosR
Copy link
Member Author

XhmikosR commented Feb 9, 2021

Yeah, that must be due to #32397

@ffoodd
Copy link
Member

ffoodd commented Feb 9, 2021

Indeed, missed that one— thanks :)

@XhmikosR XhmikosR marked this pull request as ready for review February 10, 2021 16:14
@XhmikosR XhmikosR requested review from a team as code owners February 10, 2021 16:14
@XhmikosR XhmikosR merged commit e50c11b into main Feb 10, 2021
@XhmikosR XhmikosR deleted the v5.0.0-beta2-prep branch February 10, 2021 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants