Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add focus visibility on tabs with pills #32357

Closed
wants to merge 38 commits into from
Closed
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
15dfec8
Added scss for nav-pills to focus box shadow
mayralgr Dec 7, 2020
f62e284
Change in variables, lint cleaned
mayralgr Dec 7, 2020
7d4522d
Change specificity to nav-pills-link
mayralgr Dec 7, 2020
323751c
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Dec 7, 2020
80a2bce
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Dec 9, 2020
79015e7
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Dec 9, 2020
132a492
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Dec 10, 2020
21d42be
Change nav pills box-shadow exclusively to focus
mayralgr Dec 10, 2020
7d37665
Run lint
mayralgr Dec 10, 2020
77a594f
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Dec 10, 2020
ea049c4
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Dec 10, 2020
55f6b02
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Dec 11, 2020
b440704
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Dec 11, 2020
11aba5c
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Dec 14, 2020
6651815
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Dec 15, 2020
86d0a2b
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Dec 16, 2020
c4fa5a7
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Dec 18, 2020
fa20f26
Merge branch 'main' into focus_nav_pills_tabs
patrickhlauke Dec 20, 2020
362e9e3
Merge branch 'main' into focus_nav_pills_tabs
patrickhlauke Dec 20, 2020
b9db499
Merge branch 'main' into focus_nav_pills_tabs
patrickhlauke Dec 20, 2020
35284ac
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Dec 21, 2020
3ede50d
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Dec 22, 2020
ebedd01
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Dec 28, 2020
c7679a3
Merge branch 'main' into focus_nav_pills_tabs
patrickhlauke Dec 29, 2020
dab7a65
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Dec 29, 2020
fdc42cc
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Jan 6, 2021
c2a88d2
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Jan 13, 2021
9f90cd6
Merge branch 'main' into focus_nav_pills_tabs
patrickhlauke Jan 17, 2021
e7eda31
Add outline in nav pills on focus
mayralgr Jan 18, 2021
6a7f505
Fix out-of-sync _variables.scss
patrickhlauke Jan 18, 2021
c3d07ea
Merge branch 'main' into focus_nav_pills_tabs
XhmikosR Feb 9, 2021
4d569c5
Update _nav.scss
XhmikosR Feb 9, 2021
e149d3c
Merge branch 'main' into focus_nav_pills_tabs
patrickhlauke Feb 9, 2021
7668aab
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Feb 13, 2021
78e8cee
Merge branch 'main' into focus_nav_pills_tabs
XhmikosR Feb 16, 2021
731b3d0
Merge branch 'main' into focus_nav_pills_tabs
mayralgr Mar 11, 2021
d8b999b
Merge branch 'main' into focus_nav_pills_tabs
patrickhlauke May 4, 2021
e2d3954
Merge branch 'main' into focus_nav_pills_tabs
GeoSot Aug 29, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scss/_nav.scss
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@
.nav-pills {
.nav-link {
@include border-radius($nav-pills-border-radius);
&:focus {
color: $nav-pills-link-hover-color;
text-decoration: if($link-hover-decoration == underline, none, null);
box-shadow: $nav-pills-link-focus-box-shadow;
}
patrickhlauke marked this conversation as resolved.
Show resolved Hide resolved
}

.nav-link.active,
Expand Down
5 changes: 5 additions & 0 deletions scss/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -866,6 +866,11 @@ $nav-pills-border-radius: $border-radius !default;
$nav-pills-link-active-color: $component-active-color !default;
$nav-pills-link-active-bg: $component-active-bg !default;

$nav-pills-link-hover-color: null !default;
$nav-pills-link-focus-width: .25rem !default;
$nav-pills-link-focus-color-opacity: .25 !default;
$nav-pills-link-focus-color: rgba($component-active-bg, $nav-pills-link-focus-color-opacity) !default;
$nav-pills-link-focus-box-shadow: 0 0 0 $nav-pills-link-focus-width $nav-pills-link-focus-color !default;

// Navbar

Expand Down