Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep rounded corners for the first .btn in vertical button group #31303

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Keep rounded corners for the first .btn in vertical button group #31303

merged 2 commits into from
Nov 30, 2020

Conversation

rohit2sharma95
Copy link
Contributor

Closes #31255

@rohit2sharma95 rohit2sharma95 requested a review from a team as a code owner July 15, 2020 06:56
@MartijnCuppens
Copy link
Member

This could introduce other issues like https://codepen.io/MartijnCuppens/pen/eYZKjPj?editors=1100 where you have a combination of buttons and links.

@mdo
Copy link
Member

mdo commented Sep 17, 2020

Hmm yup, and I tried > .btn:not(:first-child):not(:first-of-type) and got another problem still. Brain dead right now, will need to think more about it.

Screen Shot 2020-09-16 at 10 23 20 PM

@mdo mdo added the on-hold label Sep 17, 2020
@XhmikosR XhmikosR added the css label Oct 6, 2020
@rohit2sharma95
Copy link
Contributor Author

rohit2sharma95 commented Nov 17, 2020 •
edited
Loading

This can be achieved via Subsequent-sibling combinator I think 🤔
@MartijnCuppens

@rohit2sharma95 rohit2sharma95 force-pushed the vertical-button-group branch 2 times, most recently from 907d24f to 8814276 Compare November 17, 2020 10:06
@rohit2sharma95
Copy link
Contributor Author

Ping @mdo 🙂

MartijnCuppens
MartijnCuppens approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a neat solution @rohit2sharma95, Thanks!

@MartijnCuppens MartijnCuppens added v5 and removed on-hold labels Nov 26, 2020
@MartijnCuppens
Copy link
Member

Gonna ask for a 2nd approval from @twbs/css-review here.

ffoodd
ffoodd approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice Indeed 👌

@XhmikosR XhmikosR requested a review from mdo November 27, 2020 05:42
@XhmikosR
Copy link
Member

XhmikosR commented Nov 30, 2020 •
edited
Loading

This has an effect on our docs sidebar:

Before After
image image

Is this still ready to merge @MartijnCuppens @mdo ?

EDIT: NVM that's caused by another patch.

@XhmikosR XhmikosR merged commit af57444 into twbs:main Nov 30, 2020
@XhmikosR XhmikosR changed the title Keep rounded corners for the first .btn in vertical button group Keep rounded corners for the first .btn in vertical button group Nov 30, 2020
@rohit2sharma95 rohit2sharma95 deleted the vertical-button-group branch November 30, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@ffoodd ffoodd ffoodd approved these changes

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees
No one assigned
Labels
css no-backport-to-v4 v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vertical button group variations example has an un-rounded top
5 participants
@rohit2sharma95 @MartijnCuppens @mdo @XhmikosR @ffoodd