Docs: separate button group out of checks/radios, expand button groups page#31201
Merged
patrickhlauke merged 7 commits intomainfrom Jul 6, 2020
Merged
Docs: separate button group out of checks/radios, expand button groups page#31201patrickhlauke merged 7 commits intomainfrom
patrickhlauke merged 7 commits intomainfrom
Conversation
- give examples of the pure toggle checks and radios, without the button group class. show that these work fine without `.btn-group`, but still cross-reference it - move the explanation from "Checkbox toggle buttons" directly to "Toggle buttons", as the mention of using button classes applies equally to the subsequent "Radio toggle buttons" and "Outlined styles" subsections.
as it's not just single line, but vertical as well
patrickhlauke
force-pushed
the
v5-button-group-toggle-buttons
branch
from
d235f86 to
6e84cce
Compare
- add more colour ... `.btn-secondary` is just dull and uninspiring - new section to showcase "Checkbox and radio button groups" - add a mixed styles example - add an example of vertical radio button group
patrickhlauke
force-pushed
the
v5-button-group-toggle-buttons
branch
from
6e84cce to
42d25b5
Compare
Member
Author
|
ping @mdo et al... |
mdo
approved these changes
Jul 6, 2020
Member
mdo
left a comment
mdo
left a comment
There was a problem hiding this comment.
Looks good overall. Noticed though on the button group page, the last example under the vertical variations has an un-rounded top. Unrelated, but wanted to mention.
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
…s page (twbs#31201) * Keep checks/radio toggle buttons on topic - give examples of the pure toggle checks and radios, without the button group class. show that these work fine without `.btn-group`, but still cross-reference it - move the explanation from "Checkbox toggle buttons" directly to "Toggle buttons", as the mention of using button classes applies equally to the subsequent "Radio toggle buttons" and "Outlined styles" subsections. * Expand button group description as it's not just single line, but vertical as well * Expand button group examples - add more colour ... `.btn-secondary` is just dull and uninspiring - new section to showcase "Checkbox and radio button groups" - add a mixed styles example - add an example of vertical radio button group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In forms/checks-radios:
.btn-group, but still cross-reference itIn components/button-groups:
.btn-secondaryis just dull and uninspiringfollow-up from #30650 (comment) which suggested porting some of the docs changes trialled in #28463
Previews: checks & radios toggle buttons / button group