Skip to content

Ensure to increase contrasts on buttons & colored links hover/active states #30989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XhmikosR merged 8 commits into from
Aug 4, 2020
Merged

Ensure to increase contrasts on buttons & colored links hover/active states #30989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f564fe4
feat(buttons): ensure to increase contrasts on hover/active
ffoodd Jun 9, 2020
b3de8a4
Merge branch 'main' into master-fod-light-or-dark-hovers
XhmikosR Jun 18, 2020
4e7d68b
Merge branch 'main' into master-fod-light-or-dark-hovers
ffoodd Jun 22, 2020
368c039
Merge branch 'main' into master-fod-light-or-dark-hovers
ffoodd Jun 24, 2020
fe061ef
Merge branch 'main' into master-fod-light-or-dark-hovers
mdo Aug 3, 2020
317147d
Merge branch 'main' into master-fod-light-or-dark-hovers
XhmikosR Aug 4, 2020
77a8a5a
Update _buttons.scss
XhmikosR Aug 4, 2020
62ce9f5
Merge branch 'main' into master-fod-light-or-dark-hovers
XhmikosR Aug 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scss/helpers/_colored-links.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
@if $emphasized-link-hover-darken-percentage != 0 {
&:hover,
&:focus {
color: darken($value, $emphasized-link-hover-darken-percentage);
color: if(color-contrast($value) == $color-contrast-light, darken($value, $emphasized-link-hover-darken-percentage), lighten($value, $emphasized-link-hover-darken-percentage));
}
}
}
Expand Down
8 changes: 4 additions & 4 deletions scss/mixins/_buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
$background,
$border,
$color: color-contrast($background),
$hover-background: darken($background, 7.5%),
$hover-border: darken($border, 10%),
$hover-background: if($color == $color-contrast-light, darken($background, 7.5%), lighten($background, 7.5%)),
$hover-border: if($color == $color-contrast-light, darken($border, 10%), lighten($border, 5%)),
$hover-color: color-contrast($hover-background),
$active-background: darken($background, 10%),
$active-border: darken($border, 12.5%),
$active-background: if($color == $color-contrast-light, darken($background, 10%), lighten($background, 10%)),
$active-border: if($color == $color-contrast-light, darken($border, 12.5%), lighten($border, 5%)),
$active-color: color-contrast($active-background),
$disabled-background: $background,
$disabled-border: $border,
Expand Down