Skip to content

adds back .form-text #30565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
XhmikosR merged 7 commits into from
Apr 14, 2020
Merged

adds back .form-text #30565

XhmikosR merged 7 commits into from
Apr 14, 2020

Conversation

@zalog
Copy link
Contributor

@zalog zalog commented Apr 12, 2020 •
edited
Loading

This PR adds back .form-text css class.

@zalog zalog requested a review from a team as a code owner April 12, 2020 08:37
@zalog
Copy link
Contributor Author

zalog commented Apr 12, 2020 •
edited
Loading

@MartijnCuppens I would like to add a $form-text-color: $text-muted !default; too, what do you think?

Also, what should we do about docs? I think we should remove references about .help-block in v3, text that comes from an older version docs.

@MartijnCuppens
Copy link
Member

MartijnCuppens commented Apr 12, 2020

@MartijnCuppens I would like to add a $form-text-color: $text-muted !default; too, what do you think?

Yup! A font size variable may also be appropriate, maybe a null font-style variable.

Also, what should we do about docs?

Use .form-text where needed.

I think we should remove references about .help-block in v3, text that comes from an older version docs.

Yup.

@zalog
Copy link
Contributor Author

zalog commented Apr 13, 2020

Tnks for feedback!

Updated & done. What do you think?

@zalog zalog changed the title wip: adds back .form-text adds back .form-text Apr 13, 2020
MartijnCuppens
MartijnCuppens reviewed Apr 13, 2020
View reviewed changes
@zalog zalog force-pushed the zalog-add-form-text branch from 25889a7 to c9bf436 Compare April 13, 2020 18:33
@MartijnCuppens
Copy link
Member

MartijnCuppens commented Apr 13, 2020

Could you add a font-style (default: null)?

@zalog
Copy link
Contributor Author

zalog commented Apr 13, 2020

Yep, just a sec.
Also I saw a glitch there on a var naming.

@zalog zalog force-pushed the zalog-add-form-text branch from c9bf436 to 6900069 Compare April 13, 2020 18:58
@zalog
Copy link
Contributor Author

zalog commented Apr 13, 2020

Done

@zalog zalog force-pushed the zalog-add-form-text branch from 6900069 to a059e71 Compare April 14, 2020 04:05
@zalog
Copy link
Contributor Author

zalog commented Apr 14, 2020

Rebased

@XhmikosR XhmikosR merged commit e2afbbf into twbs:master Apr 14, 2020
@zalog zalog deleted the zalog-add-form-text branch April 14, 2020 06:23
@MartijnCuppens MartijnCuppens mentioned this pull request Apr 14, 2020
Closed
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@zalog @olsza
Restore .form-text (twbs#30565)
90f6c48
@xi xi mentioned this pull request Jan 27, 2021
Merged
xi added a commit to xi/bootstrap that referenced this pull request Jan 27, 2021
@xi
Docs v5: .form-text migration
70b13b5 
see twbs#30598 and twbs#30565
XhmikosR pushed a commit that referenced this pull request Jan 28, 2021
@xi
migration: mention .form-text changes (#32911)
e06ffa2 
see #30598 and #30565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens left review comments

@mdo mdo mdo approved these changes

Assignees

No one assigned

Labels

css v5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bring back .form-text

4 participants

@zalog @MartijnCuppens @mdo @XhmikosR