Closed
Conversation
e8c5e65 to
a7fb882
Compare
$nav-link-color$nav-link-color
Contributor
Author
|
I think we also need to add hover and active states as well. What do you think? |
5b8e005 to
81618fb
Compare
81618fb to
5bb972d
Compare
Member
Any suggestions theming wise? |
Contributor
Author
|
I'll come back here soon, this days. |
1b46fc5 to
e062656
Compare
$nav-link-color$nav-link-* vars
02209f8 to
7399051
Compare
Contributor
Author
|
Removed wip and rebased. |
Contributor
|
LGTM. FWIW, I'd go with the active state too — even if the active state should not rely on color only (but this is another topic to tackle in Bootstrap and/or examples, I guess). @MartijnCuppens Do you agree, about an active state variable? |
Bumps [stylelint](https://github.com/stylelint/stylelint) from 13.3.2 to 13.3.3. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md) - [Commits](stylelint/stylelint@13.3.2...13.3.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [karma](https://github.com/karma-runner/karma) from 5.0.1 to 5.0.2. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](karma-runner/karma@v5.0.1...v5.0.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: XhmikosR <xhmikosr@gmail.com>
mdo
added a commit
that referenced
this pull request
Jun 15, 2020
Replaces #30498 by adding four new null default variables for .nav-link. Doesn't carry over font-style from the original PR though since that's rarely used, at least by default Bootstrap. Nullifies all values from that PR, too, since we count on some basic inheritance here and don't need color by default.
Member
|
Closing for #31035. |
mdo
added a commit
that referenced
this pull request
Jul 11, 2020
Replaces #30498 by adding four new null default variables for .nav-link. Doesn't carry over font-style from the original PR though since that's rarely used, at least by default Bootstrap. Nullifies all values from that PR, too, since we count on some basic inheritance here and don't need color by default.
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
Replaces twbs#30498 by adding four new null default variables for .nav-link. Doesn't carry over font-style from the original PR though since that's rarely used, at least by default Bootstrap. Nullifies all values from that PR, too, since we count on some basic inheritance here and don't need color by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new vars for
$nav-link-*'s:This PR depends on #30622