Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require .form-label classes on form labels #30476

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Require .form-label classes on form labels #30476

merged 2 commits into from
Mar 31, 2020

Conversation

MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Mar 28, 2020 •
edited
Loading

There's currently no clean way to theme form labels, simply because they have no class. By just adding styles to the <label> element, styles can leak to other elements like the checkbox labels.

I added a new .form-label class and some null variables which makes it easier to theme these labels and prevent style leaks.

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner March 28, 2020 15:03
@MartijnCuppens MartijnCuppens force-pushed the master-mc-form-labels branch from 9c32d07 to 77a1f68 Compare March 28, 2020 15:04
@ffoodd
Copy link
Member

ffoodd commented Mar 30, 2020

Makes sense.

@MartijnCuppens
Copy link
Member Author

Gonna wait for @mdo's approval before merging this.

mdo
mdo approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've debated this for the last two major versions, so I'm definitely inclined to make the switch. Styling all <label>s led to a few extra lines, so making that update feels like a promising move for others.

@MartijnCuppens MartijnCuppens merged commit df707cd into master Mar 31, 2020
@MartijnCuppens MartijnCuppens deleted the master-mc-form-labels branch March 31, 2020 18:02
@MartijnCuppens MartijnCuppens mentioned this pull request Apr 11, 2020
Closed
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@MartijnCuppens @olsza
Require .form-label classes on form labels (twbs#30476)
4570fc6
@veganstraightedge veganstraightedge mentioned this pull request Nov 11, 2020
Merged
@stevenbuccini stevenbuccini mentioned this pull request Nov 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@ffoodd ffoodd ffoodd approved these changes

Assignees
No one assigned
Labels
css no-backport-to-v4 v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartijnCuppens @ffoodd @mdo