Closed
Conversation
5 tasks
XhmikosR
force-pushed
the
master-mc-partial-issue
branch
from
f3eb871 to
de1f75f
Compare
Member
Author
|
Gonna close this since I'm using a different technique in #30466 now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is actually an issue, I just use this to illustrate the issue with the Netlify previews.
2 newlines are added in the examples, one from the partial template, and one from the line-2.html.
By adding a dash (
{{ partial (.Get 0) . -}}) we can fix the issue in the partial template, but I'n not sure how we should handle the second newline.See https://deploy-preview-30472--twbs-bootstrap.netlify.com/docs/4.3/components/carousel/#partial-example