Use variables for list-group-item color levels#30009
Merged
MartijnCuppens merged 2 commits intotwbs:masterfrom Mar 31, 2020
Merged
Use variables for list-group-item color levels#30009MartijnCuppens merged 2 commits intotwbs:masterfrom
MartijnCuppens merged 2 commits intotwbs:masterfrom
Conversation
MartijnCuppens
approved these changes
Mar 31, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The color levels used in alerts:
bootstrap/scss/_alert.scss
Line 49 in c13ec3e
And in tables:
bootstrap/scss/_tables.scss
Line 105 in c13ec3e
Come from a variable. However the color level for list-group-item is hard coded:
bootstrap/scss/_list-group.scss
Line 159 in c13ec3e
This does strike me as inconsistent. I think all these options should be equally customizable. This PR fixes this by also putting the color levels for list-group-items into a variable.
Also note, that the default value for alert&table are both -10 and 6 for background and color respectively. However the defaults for list-group-item ist -9 and 6 for background and color respectively. I did not change this (yet) as I am not sure whether this might be on purpose.