Skip to content

Use variables for list-group-item color levels#30009

Merged
MartijnCuppens merged 2 commits intotwbs:masterfrom
yankee42:list-group-item-color-level-variables
Mar 31, 2020
Merged

Use variables for list-group-item color levels#30009
MartijnCuppens merged 2 commits intotwbs:masterfrom
yankee42:list-group-item-color-level-variables

Conversation

@yankee42
Copy link
Copy Markdown
Contributor

The color levels used in alerts:

@include alert-variant(color-level($value, $alert-bg-level), color-level($value, $alert-border-level), color-level($value, $alert-color-level));

And in tables:

@include table-row-variant($color, color-level($value, $table-bg-level), color-level($value, $table-border-level));

Come from a variable. However the color level for list-group-item is hard coded:

@include list-group-item-variant($color, color-level($value, -9), color-level($value, 6));

This does strike me as inconsistent. I think all these options should be equally customizable. This PR fixes this by also putting the color levels for list-group-items into a variable.

Also note, that the default value for alert&table are both -10 and 6 for background and color respectively. However the defaults for list-group-item ist -9 and 6 for background and color respectively. I did not change this (yet) as I am not sure whether this might be on purpose.

@yankee42 yankee42 requested a review from a team as a code owner January 13, 2020 14:15
@MartijnCuppens MartijnCuppens merged commit a1b5a64 into twbs:master Mar 31, 2020
@yankee42 yankee42 deleted the list-group-item-color-level-variables branch June 24, 2020 18:45
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants