Skip to content

Add deprecation warning#29268

Merged
MartijnCuppens merged 2 commits intov4-devfrom
v4-dev-mc-deprecate-text-emphasis-variant
Aug 26, 2019
Merged

Add deprecation warning#29268
MartijnCuppens merged 2 commits intov4-devfrom
v4-dev-mc-deprecate-text-emphasis-variant

Conversation

@MartijnCuppens
Copy link
Copy Markdown
Member

Add deprecation warning for text-emphasis-variant() mixin which will be dropped by #29267

Copy link
Copy Markdown
Member

@bardiharborow bardiharborow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, provided #29267 merges.

@MartijnCuppens MartijnCuppens merged commit 6381c63 into v4-dev Aug 26, 2019
@MartijnCuppens MartijnCuppens deleted the v4-dev-mc-deprecate-text-emphasis-variant branch August 26, 2019 07:29
@mdo mdo mentioned this pull request Aug 26, 2019
@ELI7VH
Copy link
Copy Markdown

ELI7VH commented Jan 13, 2020

what do we use instead?

@MartijnCuppens
Copy link
Copy Markdown
Member Author

MartijnCuppens commented Jan 13, 2020

@ELI7VH,

From v5 you will be able to use the text utilities https://twbs-bootstrap.netlify.com/docs/5.0/utilities/colors/#color to colorize text and https://twbs-bootstrap.netlify.com/docs/5.0/helpers/colored-links/ for links with hover states.

@Eonasdan
Copy link
Copy Markdown

@MartijnCuppens doc links are dead. I got a theme using this and I'd like to fix it.

@MartijnCuppens
Copy link
Copy Markdown
Member Author

I've just updated them. You can still use text-emphasis-variant() in v4, but make sure the 3th parameter is true.

@digitaldonkey
Copy link
Copy Markdown

It might be helpful to provide an alternative for BS 4.4+ when you add a deprecation warning.
Links above do not provide an alternative for the mixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants