Easily add display headings with sass maps

[MartijnCuppens]

Fixes #26515.

Provides a way to easily add display headings with a sass map.

[dceluis]

Will this be possible with normal text utilities? #25832

[ocarreterom]

$displays: () !default;
$displays: map-merge($displays, ());

[andresgalante]

Hi @MartijnCuppens, this solution would gives more settings and it works.

My problem is that by having the definition for headings scattered into different files, instead of scoped to type.scss we would be making the codebase harder to contribute, code and maintain.

What do you think?

[MartijnCuppens]

Hi @andresgalante,

Would you move the $displays sass map to the _type.scss? All bootstrap variables are defined in _variables.sccs, I think it's better to keep it there?

[andresgalante]

Yes, you are right, all variables are define on variables and putting them within a map wouldn't make a difference than having them as variables outside the map. The map might be a bit harder to parse.

[mdo]

You've removed several variables—that's a breaking change. You can likely rewrite the Sass map to include those variables rather than remove them outright.

[MartijnCuppens]

I re-added the original display variables

fixed

[MartijnCuppens]

I'm not convinced anymore that this is a good idea (especially for v4). This technique is quite different from the way we handle things in other places, we're practically putting every property of the generated css in a sass map.

I'm considering closing this, unless someone has a good argument to merge this.

[XhmikosR]

CC @andresgalante @mdo

[mdo]

Let's punt on it and reimagine the typography in v5 to do it right. v5 shouldn't be sweeping changes, but an easy-ish upgrade path. I feel like stuff like this can be tackled then. Feel free to close if you still agree! <3